Optimize Background Task Execution #1909
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: NAYANAR <[email protected]>
Signed-off-by: NAYANAR <[email protected]>
Signed-off-by: NAYANAR <[email protected]>
Signed-off-by: NAYANAR <[email protected]>
Collaborator
|
Hello @Nayana-R-Gowda and thank you for the PR. Please move creation of the TaskScheduler class from the services/init.py file into utils/task_scheduler.py . Once the imports have been synchronized that may clear up the linting issues. Please also be sure to rebase against the upstream repository and sign your commits. You may wish to squash commits to date when you rebase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: NAYANAR [email protected]
This change introduces a centralized, priority-based background task scheduler to coordinate all periodic tasks.
I validated the behavior using controlled asyncio tests that demonstrate:
elimination of overlapping background task execution
strict priority ordering (CRITICAL → HIGH → NORMAL → LOW)
enforced concurrency limits via a semaphore
predictable execution under load
Compared to the previous timer-based approach, this prevents DB connection spikes, reduces resource contention, and ensures critical system tasks are not delayed by housekeeping jobs.